jecsand838 commented on PR #8316: URL: https://github.com/apache/arrow-rs/pull/8316#issuecomment-3286601503
> Thank you @jecsand838 -- I found this (as always) a pleasure to read and review. Clearly it is well documented 😆 but I thought the explanations are clear, and really nice. I am proud to be able to help this implementation along > @alamb Absolutely! I appreciate your review and support as usual. I'm very excited with how close we are to getting this out! > My major suggestion is to consolidate some (maybe all) of the examples into the doc strings so they are easier to find and better tested. But I don't think that is necessary, what you have here in this PR is a clear improvement > > I also built it locally via > > ```shell > cargo doc -p arrow-avro > ``` > I think that's a solid suggestion and would be much better for the users. I'll get those changes in over the weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
