nathaniel-d-ef commented on code in PR #8371:
URL: https://github.com/apache/arrow-rs/pull/8371#discussion_r2360583870
##########
arrow-avro/src/writer/format.rs:
##########
@@ -84,25 +106,87 @@ impl AvroFormat for AvroOcfFormat {
}
}
-/// Raw Avro binary streaming format (no header or footer).
+/// Raw Avro binary streaming format using **Single-Object Encoding** per
record.
+///
+/// Each record written by the stream writer is framed with a prefix determined
+/// by the schema fingerprinting algorithm.
+///
+/// See:
<https://avro.apache.org/docs/1.11.1/specification/#single-object-encoding>
+/// See:
<https://docs.confluent.io/platform/current/schema-registry/fundamentals/serdes-develop/index.html#wire-format>
#[derive(Debug, Default)]
-pub struct AvroBinaryFormat;
+pub struct AvroBinaryFormat {
Review Comment:
I'm not sure I follow the distinction here. Are you recommending a binary
format separate from the single object encoding pattern which differs in that
it doesn't have a prefix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
