erezrokah commented on code in PR #510:
URL: https://github.com/apache/arrow-go/pull/510#discussion_r2358776126
##########
arrow/array/timestamp.go:
##########
@@ -34,11 +34,18 @@ import (
type Timestamp struct {
array
values []arrow.Timestamp
+ layout string
}
// NewTimestampData creates a new Timestamp from Data.
func NewTimestampData(data arrow.ArrayData) *Timestamp {
- a := &Timestamp{}
+ return NewTimestampDataWithLayout(data, time.RFC3339Nano)
+}
+
+// NewTimestampDataWithLayout creates a new Timestamp from Data with a custom
string value layout.
+// This is useful for cases where consumers expect a non standard layout
+func NewTimestampDataWithLayout(data arrow.ArrayData, layout string)
*Timestamp {
Review Comment:
How about `NewTimestampDataWithValueStrLayout`? Happy to change it if this
is not what you have in mind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
