alamb commented on code in PR #8365:
URL: https://github.com/apache/arrow-rs/pull/8365#discussion_r2362516196
##########
parquet-variant-compute/src/variant_get.rs:
##########
@@ -1651,7 +1633,7 @@ mod test {
}
}
- Arc::new(builder.build())
+ builder.build().into()
Review Comment:
In my opinion it was easier to understand as the type is explicitly listed.
However, I think it is just an opinion and I know others prefer the `into`
method.
I don't think there was any reason for the discrepancy in this PR -- I'll
try and make them the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
