scovich commented on code in PR #8299:
URL: https://github.com/apache/arrow-rs/pull/8299#discussion_r2334829602
##########
parquet-variant-compute/src/variant_array_builder.rs:
##########
@@ -199,9 +199,14 @@ pub struct VariantArrayVariantBuilder<'a> {
metadata_offsets: &'a mut Vec<usize>,
value_offsets: &'a mut Vec<usize>,
nulls: &'a mut NullBufferBuilder,
+ is_null: bool,
}
impl VariantBuilderExt for VariantArrayVariantBuilder<'_> {
+ /// Appending NULL to a variant array produces an actual NULL value
+ fn append_null(&mut self) {
Review Comment:
That is correct. The variant builder API is pretty broken in general if
builder methods are invoked more than once, so IMO this isn't making it any
worse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
