pitrou commented on code in PR #47466:
URL: https://github.com/apache/arrow/pull/47466#discussion_r2348052271
##########
cpp/src/parquet/statistics.cc:
##########
@@ -573,7 +578,11 @@ class TypedStatisticsImpl : public TypedStatistics<DType> {
min_buffer_(AllocateBuffer(pool_, 0)),
max_buffer_(AllocateBuffer(pool_, 0)),
logical_type_(LogicalTypeId(descr_)) {
- comparator_ = MakeComparator<DType>(descr);
+ try {
+ comparator_ = MakeComparator<DType>(descr);
Review Comment:
Instead of trying and catching, how about just not calling `MakeComparator`
if the sort order is Unknown?
(sorry, I realize I suggested try/catch above; both are ok to me, by the way)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
