Arkur745 commented on PR #47522: URL: https://github.com/apache/arrow/pull/47522#issuecomment-3292392812
@kou , @pitrou Should I implement `UnsafeAppendEmptyValue()` and `UnsafeAppendEmptyValues()` in the base ArrayBuilder class and all the concrete builder types (Int32Builder, StringBuilder , etc.) as part of this PR? This would involve: - Adding virtual method signatures to `ArrayBuilder `base class - Implementing them in all concrete builder classes - Then using them in my `StructBuilder` unsafe methods Or implement a basic version for now and leave the full concrete implementations for a separate PR? I think this should be in a separate PR with a separate issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
