kou commented on code in PR #47621:
URL: https://github.com/apache/arrow/pull/47621#discussion_r2373735080
##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -259,12 +259,23 @@ takes precedence over ccache if a storage backend is
configured" ON)
"shared"
"static")
- define_option(ARROW_FUZZING
- "Build Arrow Fuzzing executables"
+ define_option(ARROW_BUILD_FUZZING_UTILITIES
+ "Build command line utilities for fuzzing"
OFF
DEPENDS
ARROW_TESTING
- ARROW_WITH_BROTLI)
+ ARROW_WITH_BROTLI
+ ARROW_WITH_LZ4
+ ARROW_WITH_ZSTD)
+
+ define_option(ARROW_FUZZING
+ "Build Arrow fuzz targets"
+ OFF
+ DEPENDS
+ ARROW_BUILD_FUZZING_UTILITIES
+ ARROW_WITH_BROTLI
+ ARROW_WITH_LZ4
+ ARROW_WITH_ZSTD)
Review Comment:
Can we remove `ARROW_WITH_{BROTLI,LZ4,ZSTD}` because
`ARROW_BUILD_FUZZING_UTILITIES` enables them automatically?
```suggestion
ARROW_BUILD_FUZZING_UTILITIES)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
