pitrou commented on code in PR #47638:
URL: https://github.com/apache/arrow/pull/47638#discussion_r2375680100
##########
dev/conbench_envs/hooks.sh:
##########
@@ -49,13 +47,8 @@ set_arrow_build_and_run_env_vars() {
}
build_arrow_cpp() {
- export ARROW_BUILD_DIR="/tmp/$(uuidgen)"
- # Ignore the error when a cache can't be created
- if ! ci/scripts/cpp_build.sh $(pwd) $ARROW_BUILD_DIR 2> error.log; then
- if ! grep -q -F "Can\'t create temporary cache file" error.log; then
- cat error.log
- fi
- fi
+ export ARROW_BUILD_DIR="/tmp/arrow-cpp-$(uuidgen)"
+ ci/scripts/cpp_build.sh $(pwd) $ARROW_BUILD_DIR
Review Comment:
@kou It seems that a C++ build failure doesn't stop the benchmarking script
immediately. Any idea how we could solve this? Would adding `set -e` at the
beginning of this file be sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
