scovich commented on code in PR #8438:
URL: https://github.com/apache/arrow-rs/pull/8438#discussion_r2377021444
##########
parquet-variant-compute/src/variant_array.rs:
##########
@@ -843,18 +826,6 @@ fn typed_value_to_variant(typed_value: &ArrayRef, index:
usize) -> Variant<'_, '
DataType::Int64 => {
primitive_conversion_single_value!(Int64Type, typed_value, index)
}
- DataType::UInt8 => {
Review Comment:
Exactly. I don't think the shredding spec directly says that, but it's
implied because shredding is always presumed to start from binary encoded
variant values and is a more efficient representation of the same. So throwing
in random other types doesn't really make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
