aiguofer commented on code in PR #857:
URL: https://github.com/apache/arrow-java/pull/857#discussion_r2377682040
##########
adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/consumer/CompositeJdbcConsumer.java:
##########
@@ -46,9 +45,9 @@ public void consume(ResultSet rs) throws SQLException,
IOException {
BaseConsumer consumer = (BaseConsumer) consumers[i];
JdbcFieldInfo fieldInfo =
new JdbcFieldInfo(rs.getMetaData(),
consumer.columnIndexInResultSet);
- ArrowType arrowType = consumer.vector.getMinorType().getType();
+
throw new JdbcConsumerException(
- "Exception while consuming JDBC value", e, fieldInfo, arrowType);
+ "Exception while consuming JDBC value", e, fieldInfo,
consumer.vector.getMinorType());
Review Comment:
haha I was the original author! 😂 As long as I've been working with Arrow
in Java now, I can't say I fully understand all the different abstractions and
their differences, so it's very likely `getMinorType` was the only thing I saw
in auto-complete related to `type`.... But I definitely think `Field` would be
better here! thanks for the suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
