lidavidm commented on code in PR #520:
URL: https://github.com/apache/arrow-go/pull/520#discussion_r2378083568
##########
parquet/internal/encoding/types.go:
##########
@@ -113,6 +113,14 @@ type DictEncoder interface {
// of [0,dictSize) and is not validated. Returns an error if a
non-integral
// array is passed.
PutIndices(arrow.Array) error
+ // NormalizeDict takes an arrow array and normalizes it to a parquet
+ // native type. e.g. a dictionary of type int8 will be cast to an int32
+ // dictionary for parquet storage.
+ //
+ // The returned array must be released by the caller if different from
+ // the input array. If no normalization is needed, the input array
+ // may be returned as-is.
Review Comment:
That's kind of annoying, right? You have to branch. Maybe it should always
require releasing (normalize can call retain)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
