serramatutu commented on code in PR #3469:
URL: https://github.com/apache/arrow-adbc/pull/3469#discussion_r2378123731
##########
go/adbc/driver/bigquery/connection.go:
##########
@@ -685,6 +685,19 @@ func sanitizeDataset(value string) (string, error) {
}
}
+// Encode a value as a JSON string. Returns "" in case the value is empty or
if there was
+// an error
+func encodeJson[S ~[]E | ~map[string]E, E any](v S) string {
Review Comment:
I am not happy with this. But I'm not good enough at go to know a better way
to ensure `v` is JSON-encodable and can be used with `len(v)`. Happy to change
if anyone has better ideas.
This at least compiles tho :P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
