raulcd commented on code in PR #47600:
URL: https://github.com/apache/arrow/pull/47600#discussion_r2371796442
##########
dev/release/binary-task.rb:
##########
@@ -1645,45 +1645,37 @@ def define_apt_rc_tasks
progress_label = "Copying: #{distribution} #{code_name}"
progress_reporter = ProgressReporter.new(progress_label)
- distribution_dir = "#{incoming_dir}/#{distribution}"
- pool_dir = "#{distribution_dir}/pool/#{code_name}"
- rm_rf(pool_dir, verbose: verbose?)
- mkdir_p(pool_dir, verbose: verbose?)
- source_dir_prefix = "#{artifacts_dir}/#{distribution}-#{code_name}"
- # apache/arrow uses debian-bookworm-{amd64,arm64} but
- # apache/arrow-adbc uses debian-bookworm. So the following
- # glob must much both of them.
Review Comment:
is adbc still using this binary tasks? in that case we probably want to
maintain the previous behaviour for the task too?
##########
dev/release/binary-task.rb:
##########
@@ -1645,45 +1645,37 @@ def define_apt_rc_tasks
progress_label = "Copying: #{distribution} #{code_name}"
progress_reporter = ProgressReporter.new(progress_label)
- distribution_dir = "#{incoming_dir}/#{distribution}"
- pool_dir = "#{distribution_dir}/pool/#{code_name}"
- rm_rf(pool_dir, verbose: verbose?)
- mkdir_p(pool_dir, verbose: verbose?)
- source_dir_prefix = "#{artifacts_dir}/#{distribution}-#{code_name}"
- # apache/arrow uses debian-bookworm-{amd64,arm64} but
- # apache/arrow-adbc uses debian-bookworm. So the following
- # glob must much both of them.
- Dir.glob("#{source_dir_prefix}*/*") do |path|
- base_name = File.basename(path)
+ destination_prefix = "#{incoming_dir}/#{distribution}"
Review Comment:
@kou I've never done anything on ruby (I know, I should learn a little
:smiley: ). I've tested these tasks locally (`apt:rc:copy` and `yum:rc:copy`)
with a small integration test calling rake directly and seems to be working as
expected but I would appreciate some help on those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
