kylebarron commented on code in PR #8528:
URL: https://github.com/apache/arrow-rs/pull/8528#discussion_r2397948775
##########
parquet/src/schema/printer.rs:
##########
@@ -329,9 +329,20 @@ fn print_logical_and_converted(
LogicalType::Variant {
specification_version,
} => format!("VARIANT({specification_version:?})"),
- LogicalType::Geometry { crs } => format!("GEOMETRY({crs:?})"),
+ LogicalType::Geometry { crs } => {
+ if let Some(crs) = crs {
+ format!("GEOMETRY({crs})")
+ } else {
+ "GEOMETRY".to_string()
+ }
+ }
LogicalType::Geography { crs, algorithm } => {
- format!("GEOGRAPHY({crs:?},{algorithm:?})")
+ let algorithm = algorithm.unwrap_or_default();
+ if let Some(crs) = crs {
+ format!("GEOGRAPHY({algorithm}, {crs})")
Review Comment:
Just pointing out that the order of formatting was switched from
crs-algorithm to algorithm-crs. I think this is a beneficial change because the
CRS could be a long string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
