Copilot commented on code in PR #47658:
URL: https://github.com/apache/arrow/pull/47658#discussion_r2400140737
##########
cpp/src/arrow/flight/sql/odbc/odbcabstraction/odbc_impl/odbc_descriptor.cc:
##########
@@ -52,115 +52,116 @@ SQLSMALLINT CalculateHighestBoundRecord(const
std::vector<DescriptorRecord>& rec
// Public
//
=========================================================================================
-ODBCDescriptor::ODBCDescriptor(Diagnostics& baseDiagnostics, ODBCConnection*
conn,
- ODBCStatement* stmt, bool isAppDescriptor, bool
isWritable,
- bool is2xConnection)
- : m_diagnostics(baseDiagnostics.GetVendor(),
baseDiagnostics.GetDataSourceComponent(),
- driver::odbcabstraction::V_3),
- m_owningConnection(conn),
- m_parentStatement(stmt),
- m_arrayStatusPtr(nullptr),
- m_bindOffsetPtr(nullptr),
- m_rowsProccessedPtr(nullptr),
- m_arraySize(1),
- m_bindType(SQL_BIND_BY_COLUMN),
- m_highestOneBasedBoundRecord(0),
- m_is2xConnection(is2xConnection),
- m_isAppDescriptor(isAppDescriptor),
- m_isWritable(isWritable),
- m_hasBindingsChanged(true) {}
-
-Diagnostics& ODBCDescriptor::GetDiagnostics_Impl() { return m_diagnostics; }
+ODBCDescriptor::ODBCDescriptor(Diagnostics& base_diagnostics, ODBCConnection*
conn,
+ ODBCStatement* stmt, bool is_app_descriptor,
+ bool is_writable, bool is_2x_connection)
+ : diagnostics_(base_diagnostics.GetVendor(),
+ base_diagnostics.GetDataSourceComponent(),
+ driver::odbcabstraction::V_3),
+ owning_connection_(conn),
+ parent_statement_(stmt),
+ array_status_ptr_(nullptr),
+ bind_offset_ptr_(nullptr),
+ rows_proccessed_ptr_(nullptr),
+ array_size_(1),
+ bind_type_(SQL_BIND_BY_COLUMN),
+ highest_one_based_bound_record_(0),
+ is_2x_connection_(is_2x_connection),
+ is_app_descriptor_(is_app_descriptor),
+ is_writable_(is_writable),
+ has_bindings_changed_(true) {}
+
+Diagnostics& ODBCDescriptor::GetDiagnosticsImpl() { return diagnostics_; }
ODBCConnection& ODBCDescriptor::GetConnection() {
- if (m_owningConnection) {
- return *m_owningConnection;
+ if (owning_connection_) {
+ return *owning_connection_;
}
- assert(m_parentStatement);
- return m_parentStatement->GetConnection();
+ assert(parent_statement_);
+ return parent_statement_->GetConnection();
}
-void ODBCDescriptor::SetHeaderField(SQLSMALLINT fieldIdentifier, SQLPOINTER
value,
- SQLINTEGER bufferLength) {
+void ODBCDescriptor::SetHeaderField(SQLSMALLINT field_identifier, SQLPOINTER
value,
+ SQLINTEGER buffer_length) {
// Only these two fields can be set on the IRD.
- if (!m_isWritable && fieldIdentifier != SQL_DESC_ARRAY_STATUS_PTR &&
- fieldIdentifier != SQL_DESC_ROWS_PROCESSED_PTR) {
+ if (!is_writable_ && field_identifier != SQL_DESC_ARRAY_STATUS_PTR &&
+ field_identifier != SQL_DESC_ROWS_PROCESSED_PTR) {
throw DriverException("Cannot modify read-only descriptor", "HY016");
}
- switch (fieldIdentifier) {
+ switch (field_identifier) {
case SQL_DESC_ALLOC_TYPE:
throw DriverException("Invalid descriptor field", "HY091");
case SQL_DESC_ARRAY_SIZE:
- SetAttribute(value, m_arraySize);
- m_hasBindingsChanged = true;
+ SetAttribute(value, array_size_);
+ has_bindings_changed_ = true;
break;
case SQL_DESC_ARRAY_STATUS_PTR:
- SetPointerAttribute(value, m_arrayStatusPtr);
- m_hasBindingsChanged = true;
+ SetPointerAttribute(value, array_status_ptr_);
+ has_bindings_changed_ = true;
break;
case SQL_DESC_BIND_OFFSET_PTR:
- SetPointerAttribute(value, m_bindOffsetPtr);
- m_hasBindingsChanged = true;
+ SetPointerAttribute(value, bind_offset_ptr_);
+ has_bindings_changed_ = true;
break;
case SQL_DESC_BIND_TYPE:
- SetAttribute(value, m_bindType);
- m_hasBindingsChanged = true;
+ SetAttribute(value, bind_type_);
+ has_bindings_changed_ = true;
break;
case SQL_DESC_ROWS_PROCESSED_PTR:
- SetPointerAttribute(value, m_rowsProccessedPtr);
- m_hasBindingsChanged = true;
+ SetPointerAttribute(value, rows_proccessed_ptr_);
Review Comment:
Misspelled variable name 'proccessed' should be 'processed'.
##########
cpp/src/arrow/flight/sql/odbc/odbcabstraction/odbc_impl/odbc_descriptor.cc:
##########
@@ -184,390 +185,392 @@ void ODBCDescriptor::SetField(SQLSMALLINT recordNumber,
SQLSMALLINT fieldIdentif
case SQL_DESC_UPDATABLE:
throw DriverException("Cannot modify read-only field.", "HY092");
case SQL_DESC_CONCISE_TYPE:
- SetAttribute(value, record.m_conciseType);
- record.m_isBound = false;
- m_hasBindingsChanged = true;
+ SetAttribute(value, record.concise_type);
+ record.is_bound = false;
+ has_bindings_changed_ = true;
break;
case SQL_DESC_DATA_PTR:
- SetDataPtrOnRecord(value, recordNumber);
+ SetDataPtrOnRecord(value, record_number);
break;
case SQL_DESC_DATETIME_INTERVAL_CODE:
- SetAttribute(value, record.m_datetimeIntervalCode);
- record.m_isBound = false;
- m_hasBindingsChanged = true;
+ SetAttribute(value, record.datetime_interval_code);
+ record.is_bound = false;
+ has_bindings_changed_ = true;
break;
case SQL_DESC_DATETIME_INTERVAL_PRECISION:
- SetAttribute(value, record.m_datetimeIntervalPrecision);
- record.m_isBound = false;
- m_hasBindingsChanged = true;
+ SetAttribute(value, record.datetime_interval_precision);
+ record.is_bound = false;
+ has_bindings_changed_ = true;
break;
case SQL_DESC_INDICATOR_PTR:
case SQL_DESC_OCTET_LENGTH_PTR:
- SetPointerAttribute(value, record.m_indicatorPtr);
- m_hasBindingsChanged = true;
+ SetPointerAttribute(value, record.indicator_ptr);
+ has_bindings_changed_ = true;
break;
case SQL_DESC_LENGTH:
- SetAttribute(value, record.m_length);
- record.m_isBound = false;
- m_hasBindingsChanged = true;
+ SetAttribute(value, record.length);
+ record.is_bound = false;
+ has_bindings_changed_ = true;
break;
case SQL_DESC_NAME:
- SetAttributeUTF8(value, bufferLength, record.m_name);
- m_hasBindingsChanged = true;
+ SetAttributeUTF8(value, buffer_length, record.name);
+ has_bindings_changed_ = true;
break;
case SQL_DESC_OCTET_LENGTH:
- SetAttribute(value, record.m_octetLength);
- record.m_isBound = false;
- m_hasBindingsChanged = true;
+ SetAttribute(value, record.octet_length);
+ record.is_bound = false;
+ has_bindings_changed_ = true;
break;
case SQL_DESC_PARAMETER_TYPE:
- SetAttribute(value, record.m_paramType);
- record.m_isBound = false;
- m_hasBindingsChanged = true;
+ SetAttribute(value, record.param_type);
+ record.is_bound = false;
+ has_bindings_changed_ = true;
break;
case SQL_DESC_PRECISION:
- SetAttribute(value, record.m_precision);
- record.m_isBound = false;
- m_hasBindingsChanged = true;
+ SetAttribute(value, record.precision);
+ record.is_bound = false;
+ has_bindings_changed_ = true;
break;
case SQL_DESC_SCALE:
- SetAttribute(value, record.m_scale);
- record.m_isBound = false;
- m_hasBindingsChanged = true;
+ SetAttribute(value, record.scale);
+ record.is_bound = false;
+ has_bindings_changed_ = true;
break;
case SQL_DESC_TYPE:
- SetAttribute(value, record.m_type);
- record.m_isBound = false;
- m_hasBindingsChanged = true;
+ SetAttribute(value, record.type);
+ record.is_bound = false;
+ has_bindings_changed_ = true;
break;
default:
throw DriverException("Invalid descriptor field", "HY091");
}
}
-void ODBCDescriptor::GetHeaderField(SQLSMALLINT fieldIdentifier, SQLPOINTER
value,
- SQLINTEGER bufferLength,
- SQLINTEGER* outputLength) const {
- switch (fieldIdentifier) {
+void ODBCDescriptor::GetHeaderField(SQLSMALLINT field_identifier, SQLPOINTER
value,
+ SQLINTEGER buffer_length,
+ SQLINTEGER* output_length) const {
+ switch (field_identifier) {
case SQL_DESC_ALLOC_TYPE: {
SQLSMALLINT result;
- if (m_owningConnection) {
+ if (owning_connection_) {
result = SQL_DESC_ALLOC_USER;
} else {
result = SQL_DESC_ALLOC_AUTO;
}
- GetAttribute(result, value, bufferLength, outputLength);
+ GetAttribute(result, value, buffer_length, output_length);
break;
}
case SQL_DESC_ARRAY_SIZE:
- GetAttribute(m_arraySize, value, bufferLength, outputLength);
+ GetAttribute(array_size_, value, buffer_length, output_length);
break;
case SQL_DESC_ARRAY_STATUS_PTR:
- GetAttribute(m_arrayStatusPtr, value, bufferLength, outputLength);
+ GetAttribute(array_status_ptr_, value, buffer_length, output_length);
break;
case SQL_DESC_BIND_OFFSET_PTR:
- GetAttribute(m_bindOffsetPtr, value, bufferLength, outputLength);
+ GetAttribute(bind_offset_ptr_, value, buffer_length, output_length);
break;
case SQL_DESC_BIND_TYPE:
- GetAttribute(m_bindType, value, bufferLength, outputLength);
+ GetAttribute(bind_type_, value, buffer_length, output_length);
break;
case SQL_DESC_ROWS_PROCESSED_PTR:
- GetAttribute(m_rowsProccessedPtr, value, bufferLength, outputLength);
+ GetAttribute(rows_proccessed_ptr_, value, buffer_length, output_length);
Review Comment:
Misspelled variable name 'proccessed' should be 'processed'.
```suggestion
GetAttribute(rows_processed_ptr_, value, buffer_length, output_length);
```
##########
cpp/src/arrow/flight/sql/odbc/odbcabstraction/odbc_impl/odbc_descriptor.cc:
##########
@@ -52,115 +52,116 @@ SQLSMALLINT CalculateHighestBoundRecord(const
std::vector<DescriptorRecord>& rec
// Public
//
=========================================================================================
-ODBCDescriptor::ODBCDescriptor(Diagnostics& baseDiagnostics, ODBCConnection*
conn,
- ODBCStatement* stmt, bool isAppDescriptor, bool
isWritable,
- bool is2xConnection)
- : m_diagnostics(baseDiagnostics.GetVendor(),
baseDiagnostics.GetDataSourceComponent(),
- driver::odbcabstraction::V_3),
- m_owningConnection(conn),
- m_parentStatement(stmt),
- m_arrayStatusPtr(nullptr),
- m_bindOffsetPtr(nullptr),
- m_rowsProccessedPtr(nullptr),
- m_arraySize(1),
- m_bindType(SQL_BIND_BY_COLUMN),
- m_highestOneBasedBoundRecord(0),
- m_is2xConnection(is2xConnection),
- m_isAppDescriptor(isAppDescriptor),
- m_isWritable(isWritable),
- m_hasBindingsChanged(true) {}
-
-Diagnostics& ODBCDescriptor::GetDiagnostics_Impl() { return m_diagnostics; }
+ODBCDescriptor::ODBCDescriptor(Diagnostics& base_diagnostics, ODBCConnection*
conn,
+ ODBCStatement* stmt, bool is_app_descriptor,
+ bool is_writable, bool is_2x_connection)
+ : diagnostics_(base_diagnostics.GetVendor(),
+ base_diagnostics.GetDataSourceComponent(),
+ driver::odbcabstraction::V_3),
+ owning_connection_(conn),
+ parent_statement_(stmt),
+ array_status_ptr_(nullptr),
+ bind_offset_ptr_(nullptr),
+ rows_proccessed_ptr_(nullptr),
Review Comment:
Misspelled variable name 'proccessed' should be 'processed'.
```suggestion
rows_processed_ptr_(nullptr),
```
##########
cpp/src/arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/odbc_impl/odbc_descriptor.h:
##########
@@ -81,79 +81,79 @@ class ODBCDescriptor : public ODBCHandle<ODBCDescriptor> {
/// \brief Construct a new ODBCDescriptor object. Link the descriptor to a
connection,
/// if applicable. A nullptr should be supplied for conn if the descriptor
should not be
/// linked.
- ODBCDescriptor(driver::odbcabstraction::Diagnostics& baseDiagnostics,
- ODBCConnection* conn, ODBCStatement* stmt, bool
isAppDescriptor,
- bool isWritable, bool is2xConnection);
+ ODBCDescriptor(driver::odbcabstraction::Diagnostics& base_diagnostics,
+ ODBCConnection* conn, ODBCStatement* stmt, bool
is_app_descriptor,
+ bool is_writable, bool is_2x_connection);
- driver::odbcabstraction::Diagnostics& GetDiagnostics_Impl();
+ driver::odbcabstraction::Diagnostics& GetDiagnosticsImpl();
ODBCConnection& GetConnection();
- void SetHeaderField(SQLSMALLINT fieldIdentifier, SQLPOINTER value,
- SQLINTEGER bufferLength);
- void SetField(SQLSMALLINT recordNumber, SQLSMALLINT fieldIdentifier,
SQLPOINTER value,
- SQLINTEGER bufferLength);
- void GetHeaderField(SQLSMALLINT fieldIdentifier, SQLPOINTER value,
- SQLINTEGER bufferLength, SQLINTEGER* outputLength) const;
- void GetField(SQLSMALLINT recordNumber, SQLSMALLINT fieldIdentifier,
SQLPOINTER value,
- SQLINTEGER bufferLength, SQLINTEGER* outputLength);
- SQLSMALLINT getAllocType() const;
+ void SetHeaderField(SQLSMALLINT field_identifier, SQLPOINTER value,
+ SQLINTEGER buffer_length);
+ void SetField(SQLSMALLINT record_number, SQLSMALLINT field_identifier,
SQLPOINTER value,
+ SQLINTEGER buffer_length);
+ void GetHeaderField(SQLSMALLINT field_identifier, SQLPOINTER value,
+ SQLINTEGER buffer_length, SQLINTEGER* output_length)
const;
+ void GetField(SQLSMALLINT record_number, SQLSMALLINT field_identifier,
SQLPOINTER value,
+ SQLINTEGER buffer_length, SQLINTEGER* output_length);
+ SQLSMALLINT GetAllocType() const;
bool IsAppDescriptor() const;
- inline bool HaveBindingsChanged() const { return m_hasBindingsChanged; }
+ inline bool HaveBindingsChanged() const { return has_bindings_changed_; }
- void RegisterToStatement(ODBCStatement* statement, bool isApd);
- void DetachFromStatement(ODBCStatement* statement, bool isApd);
+ void RegisterToStatement(ODBCStatement* statement, bool is_apd);
+ void DetachFromStatement(ODBCStatement* statement, bool is_apd);
void ReleaseDescriptor();
void
PopulateFromResultSetMetadata(driver::odbcabstraction::ResultSetMetadata* rsmd);
const std::vector<DescriptorRecord>& GetRecords() const;
std::vector<DescriptorRecord>& GetRecords();
- void BindCol(SQLSMALLINT recordNumber, SQLSMALLINT cType, SQLPOINTER dataPtr,
- SQLLEN bufferLength, SQLLEN* indicatorPtr);
- void SetDataPtrOnRecord(SQLPOINTER dataPtr, SQLSMALLINT recNumber);
+ void BindCol(SQLSMALLINT record_number, SQLSMALLINT c_type, SQLPOINTER
data_ptr,
+ SQLLEN buffer_length, SQLLEN* indicator_ptr);
+ void SetDataPtrOnRecord(SQLPOINTER data_ptr, SQLSMALLINT rec_number);
- inline SQLULEN GetBindOffset() { return m_bindOffsetPtr ? *m_bindOffsetPtr :
0UL; }
+ inline SQLULEN GetBindOffset() { return bind_offset_ptr_ ? *bind_offset_ptr_
: 0UL; }
inline SQLULEN GetBoundStructOffset() {
- // If this is SQL_BIND_BY_COLUMN, m_bindType is zero which indicates no
offset due to
+ // If this is SQL_BIND_BY_COLUMN, bind_type_ is zero which indicates no
offset due to
// use of a bound struct. If this is non-zero, row-wise binding is being
used so the
// app should set this to sizeof(their struct).
- return m_bindType;
+ return bind_type_;
}
- inline SQLULEN GetArraySize() { return m_arraySize; }
+ inline SQLULEN GetArraySize() { return array_size_; }
- inline SQLUSMALLINT* GetArrayStatusPtr() { return m_arrayStatusPtr; }
+ inline SQLUSMALLINT* GetArrayStatusPtr() { return array_status_ptr_; }
inline void SetRowsProcessed(SQLULEN rows) {
- if (m_rowsProccessedPtr) {
- *m_rowsProccessedPtr = rows;
+ if (rows_proccessed_ptr_) {
+ *rows_proccessed_ptr_ = rows;
Review Comment:
Misspelled variable name 'proccessed' should be 'processed'.
##########
cpp/src/arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/odbc_impl/odbc_descriptor.h:
##########
@@ -81,79 +81,79 @@ class ODBCDescriptor : public ODBCHandle<ODBCDescriptor> {
/// \brief Construct a new ODBCDescriptor object. Link the descriptor to a
connection,
/// if applicable. A nullptr should be supplied for conn if the descriptor
should not be
/// linked.
- ODBCDescriptor(driver::odbcabstraction::Diagnostics& baseDiagnostics,
- ODBCConnection* conn, ODBCStatement* stmt, bool
isAppDescriptor,
- bool isWritable, bool is2xConnection);
+ ODBCDescriptor(driver::odbcabstraction::Diagnostics& base_diagnostics,
+ ODBCConnection* conn, ODBCStatement* stmt, bool
is_app_descriptor,
+ bool is_writable, bool is_2x_connection);
- driver::odbcabstraction::Diagnostics& GetDiagnostics_Impl();
+ driver::odbcabstraction::Diagnostics& GetDiagnosticsImpl();
ODBCConnection& GetConnection();
- void SetHeaderField(SQLSMALLINT fieldIdentifier, SQLPOINTER value,
- SQLINTEGER bufferLength);
- void SetField(SQLSMALLINT recordNumber, SQLSMALLINT fieldIdentifier,
SQLPOINTER value,
- SQLINTEGER bufferLength);
- void GetHeaderField(SQLSMALLINT fieldIdentifier, SQLPOINTER value,
- SQLINTEGER bufferLength, SQLINTEGER* outputLength) const;
- void GetField(SQLSMALLINT recordNumber, SQLSMALLINT fieldIdentifier,
SQLPOINTER value,
- SQLINTEGER bufferLength, SQLINTEGER* outputLength);
- SQLSMALLINT getAllocType() const;
+ void SetHeaderField(SQLSMALLINT field_identifier, SQLPOINTER value,
+ SQLINTEGER buffer_length);
+ void SetField(SQLSMALLINT record_number, SQLSMALLINT field_identifier,
SQLPOINTER value,
+ SQLINTEGER buffer_length);
+ void GetHeaderField(SQLSMALLINT field_identifier, SQLPOINTER value,
+ SQLINTEGER buffer_length, SQLINTEGER* output_length)
const;
+ void GetField(SQLSMALLINT record_number, SQLSMALLINT field_identifier,
SQLPOINTER value,
+ SQLINTEGER buffer_length, SQLINTEGER* output_length);
+ SQLSMALLINT GetAllocType() const;
bool IsAppDescriptor() const;
- inline bool HaveBindingsChanged() const { return m_hasBindingsChanged; }
+ inline bool HaveBindingsChanged() const { return has_bindings_changed_; }
- void RegisterToStatement(ODBCStatement* statement, bool isApd);
- void DetachFromStatement(ODBCStatement* statement, bool isApd);
+ void RegisterToStatement(ODBCStatement* statement, bool is_apd);
+ void DetachFromStatement(ODBCStatement* statement, bool is_apd);
void ReleaseDescriptor();
void
PopulateFromResultSetMetadata(driver::odbcabstraction::ResultSetMetadata* rsmd);
const std::vector<DescriptorRecord>& GetRecords() const;
std::vector<DescriptorRecord>& GetRecords();
- void BindCol(SQLSMALLINT recordNumber, SQLSMALLINT cType, SQLPOINTER dataPtr,
- SQLLEN bufferLength, SQLLEN* indicatorPtr);
- void SetDataPtrOnRecord(SQLPOINTER dataPtr, SQLSMALLINT recNumber);
+ void BindCol(SQLSMALLINT record_number, SQLSMALLINT c_type, SQLPOINTER
data_ptr,
+ SQLLEN buffer_length, SQLLEN* indicator_ptr);
+ void SetDataPtrOnRecord(SQLPOINTER data_ptr, SQLSMALLINT rec_number);
- inline SQLULEN GetBindOffset() { return m_bindOffsetPtr ? *m_bindOffsetPtr :
0UL; }
+ inline SQLULEN GetBindOffset() { return bind_offset_ptr_ ? *bind_offset_ptr_
: 0UL; }
inline SQLULEN GetBoundStructOffset() {
- // If this is SQL_BIND_BY_COLUMN, m_bindType is zero which indicates no
offset due to
+ // If this is SQL_BIND_BY_COLUMN, bind_type_ is zero which indicates no
offset due to
// use of a bound struct. If this is non-zero, row-wise binding is being
used so the
// app should set this to sizeof(their struct).
- return m_bindType;
+ return bind_type_;
}
- inline SQLULEN GetArraySize() { return m_arraySize; }
+ inline SQLULEN GetArraySize() { return array_size_; }
- inline SQLUSMALLINT* GetArrayStatusPtr() { return m_arrayStatusPtr; }
+ inline SQLUSMALLINT* GetArrayStatusPtr() { return array_status_ptr_; }
inline void SetRowsProcessed(SQLULEN rows) {
- if (m_rowsProccessedPtr) {
- *m_rowsProccessedPtr = rows;
+ if (rows_proccessed_ptr_) {
+ *rows_proccessed_ptr_ = rows;
}
}
- inline void NotifyBindingsHavePropagated() { m_hasBindingsChanged = false; }
+ inline void NotifyBindingsHavePropagated() { has_bindings_changed_ = false; }
- inline void NotifyBindingsHaveChanged() { m_hasBindingsChanged = true; }
+ inline void NotifyBindingsHaveChanged() { has_bindings_changed_ = true; }
private:
- driver::odbcabstraction::Diagnostics m_diagnostics;
- std::vector<ODBCStatement*> m_registeredOnStatementsAsApd;
- std::vector<ODBCStatement*> m_registeredOnStatementsAsArd;
- std::vector<DescriptorRecord> m_records;
- ODBCConnection* m_owningConnection;
- ODBCStatement* m_parentStatement;
- SQLUSMALLINT* m_arrayStatusPtr;
- SQLULEN* m_bindOffsetPtr;
- SQLULEN* m_rowsProccessedPtr;
- SQLULEN m_arraySize;
- SQLINTEGER m_bindType;
- SQLSMALLINT m_highestOneBasedBoundRecord;
- const bool m_is2xConnection;
- bool m_isAppDescriptor;
- bool m_isWritable;
- bool m_hasBindingsChanged;
+ driver::odbcabstraction::Diagnostics diagnostics_;
+ std::vector<ODBCStatement*> registered_on_statements_as_apd_;
+ std::vector<ODBCStatement*> registered_on_statements_as_ard_;
+ std::vector<DescriptorRecord> records_;
+ ODBCConnection* owning_connection_;
+ ODBCStatement* parent_statement_;
+ SQLUSMALLINT* array_status_ptr_;
+ SQLULEN* bind_offset_ptr_;
+ SQLULEN* rows_proccessed_ptr_;
Review Comment:
Misspelled variable name 'proccessed' should be 'processed'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
