alamb commented on code in PR #8530: URL: https://github.com/apache/arrow-rs/pull/8530#discussion_r2413678015
########## parquet/src/file/metadata/mod.rs: ########## @@ -17,9 +17,7 @@ //! Parquet metadata API //! -//! Most users should use these structures to interact with Parquet metadata. -//! The [crate::format] module contains lower level structures generated from the -//! Parquet thrift definition. +//! Users should use these structures to interact with Parquet metadata. Review Comment: ❤️ ########## parquet/THRIFT.md: ########## @@ -0,0 +1,447 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> Review Comment: Filed a ticket to incorporate some of this content into the doc comments: - https://github.com/apache/arrow-rs/issues/8571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
