dangotbanned commented on code in PR #47609: URL: https://github.com/apache/arrow/pull/47609#discussion_r2426374406
########## python/pyproject.toml: ########## @@ -83,11 +83,61 @@ include = ["pyarrow"] namespaces = false [tool.setuptools.package-data] -pyarrow = ["*.pxd", "*.pyx", "includes/*.pxd"] +pyarrow = ["*.pxd", "*.pyx", "includes/*.pxd", "py.typed"] [tool.setuptools_scm] root = '..' version_file = 'pyarrow/_generated_version.py' version_scheme = 'guess-next-dev' git_describe_command = 'git describe --dirty --tags --long --match "apache-arrow-[0-9]*.*"' fallback_version = '22.0.0a0' + +[tool.mypy] +files = ["pyarrow"] +exclude = 'pyarrow/interchange/.*|pyarrow/vendored/.*' +mypy_path = "$MYPY_CONFIG_FILE_DIR/pyarrow-stubs" + +[tool.pyright] +include = ["pyarrow"] Review Comment: Ah nice one thanks @rok Looking into the `pyright` errors from (https://github.com/apache/arrow/pull/47609#discussion_r2426056272) some more, it seems like 3 of the most common ones are explicitly disabled in your config: - [reportCallIssue](https://github.com/microsoft/pylance-release/blob/main/docs/diagnostics/reportCallIssue.md) - [reportArgumentType](https://github.com/microsoft/pylance-release/blob/ed7a9b333b2fbe87f08595c24db7b7d371090031/docs/diagnostics/reportArgumentType.md) - [reportAttributeAccessIssue](https://github.com/microsoft/pylance-release/blob/main/docs/diagnostics/reportAttributeAccessIssue.md) Also [reportAssignmentType](https://github.com/microsoft/pylance-release/blob/main/docs/diagnostics/reportAssignmentType.md) appears to be disabled as a result of [`reportGeneralTypeIssues = "none"`](https://microsoft.github.io/pyright/#/configuration?id=diagnostic-settings-defaults). As that setting disables the majority of `pyright` rules, is this a temporary thing to work-around a high number of errors? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
