CurtHagenlocher commented on code in PR #3422:
URL: https://github.com/apache/arrow-adbc/pull/3422#discussion_r2426744177
##########
csharp/src/Drivers/Apache/ApacheUtility.cs:
##########
@@ -98,18 +98,6 @@ public static bool BooleanIsValid(string key, string value,
out bool booleanValu
public static bool ContainsException<T>(Exception exception, out T?
containedException) where T : Exception
Review Comment:
FWIW, this could share an implementation with the other overload via e.g.
```
public static bool ContainsException<T>(Exception exception, out T?
containedException) where T: Exception
{
if (ContainsException(exception, typeof(T), out Exception? found))
{
containedException = (T)found;
return true;
}
containedException = default;
return false;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
