friendlymatthew commented on code in PR #8625:
URL: https://github.com/apache/arrow-rs/pull/8625#discussion_r2432836436
##########
parquet-variant-compute/src/variant_array.rs:
##########
@@ -439,6 +440,20 @@ impl From<VariantArray> for ArrayRef {
}
}
+impl<'m, 'v> FromIterator<Option<Variant<'m, 'v>>> for VariantArray {
Review Comment:
Yeah, I thought about this as well, but I figured we'd be creating 2
abstractions?
As in, I wonder if it's better to guide the user to do the `Variant::from`
explicitly 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
