eric-wang-1990 commented on code in PR #3577:
URL: https://github.com/apache/arrow-adbc/pull/3577#discussion_r2433119224
##########
csharp/src/Drivers/Databricks/DatabricksConnection.cs:
##########
@@ -695,31 +739,88 @@ protected override TOpenSessionReq CreateSessionRequest()
req.Configuration[property.Key] = property.Value;
}
}
+
+ Activity.Current?.SetTag("connection.configuration_count",
req.Configuration.Count);
+
Activity.Current?.AddEvent("connection.open_session_request.created");
+
return req;
}
protected override async Task
HandleOpenSessionResponse(TOpenSessionResp? session, Activity? activity =
default)
{
+ activity?.AddEvent("connection.open_session_response.received");
Review Comment:
It seems that since this HandleOpenSessionresponse is called from after this
OpenSession
https://github.com/apache/arrow-adbc/blob/cc33312ddcdd9f6ceb67c05d8fd9576310645249/csharp/src/Drivers/Apache/Hive2/HiveServer2Connection.cs#L359,
and operation to the activity after that call will somehow not be serialized
to the log. Do you have any idea why? @birschick-bq
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
