sdf-jkl commented on code in PR #8600:
URL: https://github.com/apache/arrow-rs/pull/8600#discussion_r2429314591
##########
parquet-variant-compute/src/variant_to_arrow.rs:
##########
@@ -52,6 +53,12 @@ pub(crate) enum PrimitiveVariantToArrowRowBuilder<'a> {
TimestampNano(VariantToTimestampArrowRowBuilder<'a,
datatypes::TimestampNanosecondType>),
TimestampNanoNtz(VariantToTimestampNtzArrowRowBuilder<'a,
datatypes::TimestampNanosecondType>),
Date(VariantToPrimitiveArrowRowBuilder<'a, datatypes::Date32Type>),
+ StringView(VariantToUtf8ViewArrowBuilder<'a>),
Review Comment:
Allocating memory for primitive builders only requires a `capacity` field
for the number of items to pre-allocate.
For `Utf8/LargeUtf8` builders `capacity` **and** another field are required:
`data_capacity` - the total number of (utf8) bytes to allocate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
