klion26 commented on code in PR #8444:
URL: https://github.com/apache/arrow-rs/pull/8444#discussion_r2386989796
##########
parquet-variant-compute/src/variant_array.rs:
##########
@@ -627,47 +627,38 @@ impl From<ShreddedVariantFieldArray> for StructArray {
///
/// | value | typed_value | Meaning |
/// |----------|--------------|---------|
-/// | null | null | The value is missing; only valid for shredded
object fields |
-/// | non-null | null | The value is present and may be any type,
including `null` |
-/// | null | non-null | The value is present and is the shredded type |
-/// | non-null | non-null | The value is present and is a partially
shredded object |
+/// | NULL | NULL | The value is missing; only valid for shredded
object fields |
+/// | non-NULL | NULL | The value is present and may be any type,
including [`Variant::Null`] |
+/// | NULL | non-NULL | The value is present and is the shredded type |
+/// | non-NULL | non-NULL | The value is present and is a partially
shredded object |
+///
+///
+/// Applying the above rules to entire columns, we obtain the following:
+///
+/// | value | typed_value | Meaning |
+/// |--------|-------------|---------|
+/// | -- | -- | **Missing**: The value is always missing; only
valid for shredded object fields |
Review Comment:
Thanks for this comment!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
