mbrobbel commented on code in PR #8489:
URL: https://github.com/apache/arrow-rs/pull/8489#discussion_r2389046502
##########
arrow-schema/src/ffi.rs:
##########
@@ -98,20 +98,20 @@ unsafe extern "C" fn release_schema(schema: *mut
FFI_ArrowSchema) {
if schema.is_null() {
return;
}
- let schema = &mut *schema;
+ let schema = unsafe { &mut *schema };
Review Comment:
We can use large `unsafe` blocks, but in
https://github.com/apache/arrow-rs/pull/8450#pullrequestreview-3272030366 and
for example https://github.com/apache/arrow-rs/pull/8455#discussion_r2382254595
@crepererum suggests to minimize the size of the `unsafe` blocks to help with
unsafe code reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
