etseidl commented on issue #8517: URL: https://github.com/apache/arrow-rs/issues/8517#issuecomment-3374373971
Only good news now. I've removed some of the worst `convert_` functions with and without encryption support. Benchmarks look good. ``` group gh5854 no_conv ----- ------ ------- decode parquet metadata 1.08 19.5±0.37µs ? ?/sec 1.00 18.1±0.35µs ? ?/sec decode parquet metadata (wide) 1.14 90.7±3.11ms ? ?/sec 1.00 79.6±1.52ms ? ?/sec open(default) 1.13 21.2±0.64µs ? ?/sec 1.00 18.8±0.52µs ? ?/sec open(page index) 1.00 257.5±5.27µs ? ?/sec 1.00 257.0±4.10µs ? ?/sec ``` I have noticed, however, that there is a regression due to the encryption, even for calls that are encryption unaware (the "decode parquet metadata" benches). ``` group no_conv no_conv_no_encr ----- ------- --------------- decode parquet metadata 1.04 18.1±0.35µs ? ?/sec 1.00 17.4±0.72µs ? ?/sec decode parquet metadata (wide) 1.07 79.6±1.52ms ? ?/sec 1.00 74.3±1.67ms ? ?/sec open(default) 1.04 18.8±0.52µs ? ?/sec 1.00 18.0±0.31µs ? ?/sec open(page index) 1.01 257.0±4.10µs ? ?/sec 1.00 255.1±5.80µs ? ?/sec ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
