[GitHub] [arrow] ianmcook commented on a change in pull request #10056: ARROW-12184: [R] Bindings for na.fail, na.omit, na.exclude, na.pass

Mon, 19 Apr 2021 16:18:55 -0700 


ianmcook commented on a change in pull request #10056:
URL: https://github.com/apache/arrow/pull/10056#discussion_r616238310



##########
File path: r/tests/testthat/helper-expectation.R
##########
@@ -189,3 +187,109 @@ expect_vector_equal <- function(expr, # A vectorized R 
expression containing `in
     skip(paste(skip_msg, collpase = "\n"))
   }
 }
+
+expect_vector_equivalent <- function(expr, # A vectorized R expression 
containing `input` as its input

Review comment:
       Agreed—best to name the attribute`ignore_attr` 👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to