lidavidm commented on code in PR #3591:
URL: https://github.com/apache/arrow-adbc/pull/3591#discussion_r2443717861
##########
c/driver/sqlite/CMakeLists.txt:
##########
@@ -68,6 +68,16 @@ foreach(LIB_TARGET ${ADBC_LIBRARIES})
if(NOT ADBC_DEFINE_COMMON_ENTRYPOINTS)
target_compile_definitions(${LIB_TARGET} PRIVATE
${ADBC_TARGET_COMPILE_DEFINITIONS})
endif()
+
+ # On Windows, install sqlite3.dll alongside the driver
+ if(WIN32 AND CMAKE_VERSION VERSION_GREATER_EQUAL "3.21")
Review Comment:
I guess then the problem is it won't work on older CMake!
Our minimum is 3.18 right now but maybe we can bump it up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
