AntoinePrv commented on PR #47910:
URL: https://github.com/apache/arrow/pull/47910#issuecomment-3432346545

   Thanks for looking into this!
   
   For reference, I did no create a `_neon` file because to reproduce the 
pattern used for `byte_stream_split`.
   ```
   cpp/src/arrow/util/byte_stream_split_internal.cc
   cpp/src/arrow/util/byte_stream_split_internal.h
   cpp/src/arrow/util/byte_stream_split_internal_avx2.cc
   cpp/src/arrow/util/byte_stream_split_test.cc
   ```
   
   The fix works, but I am also working on this files, and may add an SSE 
compilation that will share the same xsimd code as the Neon one (hence the 
undescriptive `_default`).
   
   I believe that, equivalently to the `byte_stream_split`, we can only gate 
the `#include`s  in `bpacking_simd_default.cc` behind `#if 
defined(ARROW_HAVE_NEON)` to resolve this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to