lidavidm commented on code in PR #3606:
URL: https://github.com/apache/arrow-adbc/pull/3606#discussion_r2453595440


##########
python/adbc_driver_postgresql/adbc_driver_postgresql/dbapi.py:
##########


Review Comment:
   What might be even better is to change the signature to `, *, autocommit: 
bool=False, **kwargs` so that autocommit can potentially be picked up by 
autocomplete.



##########
python/adbc_driver_postgresql/README.md:
##########


Review Comment:
   I don't think we need to add things to the readme. Maybe add a recipe 
instead? 
https://github.com/apache/arrow-adbc/blob/main/docs/source/python/recipe/postgresql.rst



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to