peasee commented on code in PR #517: URL: https://github.com/apache/arrow-rs-object-store/pull/517#discussion_r2463124794
########## src/lib.rs: ########## @@ -324,6 +324,32 @@ //! # } //! ``` //! +//! To retrieve ranges from a versioned object, use [`ObjectStore::get_opts`] by specifying the range in the [`GetOptions`]. +//! +//! ```ignore-wasm32 Review Comment: It looks like only a few doc examples are excluded on wasm32. A number of them build (but don't necessarily run) like the [conditional fetch example](https://github.com/apache/arrow-rs-object-store/blob/main/src/lib.rs#L376). With the docs target disabled, only a single wasm test [`basic_wasm_get`](https://github.com/apache/arrow-rs-object-store/blob/main/tests/http.rs#L50) runs so I think we should retain the `ignore-wasm32` and keep building the other docs targets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
