returnString opened a new pull request #25: URL: https://github.com/apache/arrow-datafusion/pull/25
As mentioned in apache/arrow#10049 as a potential followup, this PR simplifies metrics management in physical ops by removing the need for a mutex around `SQLMetric` instances, instead using atomics to track metric values. I've also removed the `name` field as this info is duplicated by `ExecutionPlan::metrics` returning a string-keyed map. Happy to revert that portion of the change if people feel strongly about it though! It might be possible to futher simplify this by removing the `Arc` allocs and sharing `SQLMetric` instances as `Sync` references if the existing lifetime setup plays nicely with it, but I didn't want to spend _too_ much time digging into this; I think this PR as-is gives us the immediate win of not needing to deal with mutexes :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
