GeorgeLeePatterson opened a new pull request, #322:
URL: https://github.com/apache/arrow-js/pull/322

   ## What's Changed
   
   This PR adds write support for BinaryView and Utf8View types through builder 
classes, completing the BinaryView/Utf8View implementation started in #320.
   
   ## Implementation Details
   
   ### Builders
   - BinaryViewBuilder and Utf8ViewBuilder in `src/builder/binaryview.ts` and 
`src/builder/utf8view.ts`
   - Implements 16-byte view struct layout with inline/out-of-line storage 
strategy
   - Variadic buffer management with 32MB buffer chunks (per Arrow spec)
   - Proper flush() to pass views and variadicBuffers to makeData
   
   ### Integration
   - Added to builderctor visitor for factory support
   - Exported from Arrow.ts and Arrow.dom.ts for public API
   
   ## What Works
   - [X] Building BinaryView/Utf8View columns from JavaScript data
   - [X] Automatic inline (≤12 bytes) vs out-of-line (>12 bytes) storage
   - [X] Variadic buffer chunking for large datasets
   - [X] Round-trip: build → flush → read
   
   ## Testing
   - [X] Comprehensive unit tests in test/unit/builders/view-builders-tests.ts
   - [X] Tests verify inline/out-of-line thresholds, null handling, variadic 
buffers
   - [X] All existing tests pass
   - [X] CI validated on fork
   
   Builds on #320


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to