trxcllnt commented on code in PR #320:
URL: https://github.com/apache/arrow-js/pull/320#discussion_r2484247914
##########
src/visitor/vectorloader.ts:
##########
@@ -142,6 +157,20 @@ export class VectorLoader extends Visitor {
protected readData<T extends DataType>(_type: T, { length, offset } =
this.nextBufferRange()) {
return this.bytes.subarray(offset, offset + length);
}
+ protected readVariadicBuffers(count: number) {
+ if (count <= 0) {
+ return [] as Uint8Array[];
+ }
+ const buffers: Uint8Array[] = [];
+ for (let i = 0; i < count; ++i) {
+ const { length, offset } = this.nextBufferRange();
+ buffers[i] = this.bytes.subarray(offset, offset + length);
+ }
+ return buffers;
+ }
Review Comment:
protected readVariadicBuffers(length: number) {
Array.from({length}, () => this.readData(null))
}
##########
src/visitor/vectorloader.ts:
##########
@@ -142,6 +157,20 @@ export class VectorLoader extends Visitor {
protected readData<T extends DataType>(_type: T, { length, offset } =
this.nextBufferRange()) {
return this.bytes.subarray(offset, offset + length);
}
+ protected readVariadicBuffers(count: number) {
+ if (count <= 0) {
+ return [] as Uint8Array[];
+ }
+ const buffers: Uint8Array[] = [];
+ for (let i = 0; i < count; ++i) {
+ const { length, offset } = this.nextBufferRange();
+ buffers[i] = this.bytes.subarray(offset, offset + length);
+ }
+ return buffers;
+ }
Review Comment:
```suggestion
protected readVariadicBuffers(length: number) {
Array.from({length}, () => this.readData(null))
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
