kylebarron commented on code in PR #8772: URL: https://github.com/apache/arrow-rs/pull/8772#discussion_r2487385418
########## arrow-buffer/src/buffer/scalar.rs: ########## @@ -29,17 +29,35 @@ use std::ops::Deref; /// with the following differences: /// /// - slicing and cloning is O(1). -/// - it supports external allocated memory +/// - support for external allocated memory (e.g. via FFI). /// +/// See [`Buffer`] for more low-level memory management details. +/// +/// # Example: Convert to/from Vec (without copies) /// ``` /// # use arrow_buffer::ScalarBuffer; /// // Zero-copy conversion from Vec /// let buffer = ScalarBuffer::from(vec![1, 2, 3]); /// assert_eq!(&buffer, &[1, 2, 3]); +/// // convert the buffer back to Vec without copy assuming: +/// // 1. the inner buffer is not sliced +/// // 2. the inner buffer uses standard allocation Review Comment: I think @mbrobbel 's comment applies here too https://github.com/apache/arrow-rs/pull/8771#discussion_r2486648522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
