mbrobbel commented on code in PR #8777:
URL: https://github.com/apache/arrow-rs/pull/8777#discussion_r2489158101
##########
parquet/src/file/serialized_reader.rs:
##########
@@ -2696,4 +2696,23 @@ mod tests {
);
}
}
+
+ #[test]
+ fn test_read_unknown_logical_type() {
+ let file = get_test_file("unknown-logical-type.parquet");
+ let reader = SerializedFileReader::new(file).unwrap();
+ let mut iter = reader
+ .get_row_iter(None)
+ .expect("Failed to create row iterator");
+
+ let mut start = 0;
+ let end = reader.metadata().file_metadata().num_rows();
+ while start < end {
+ match iter.next() {
+ Some(_) => {}
+ None => break,
+ };
+ start += 1;
+ }
Review Comment:
Should we `assert_eq!(start, end)` here or is it good enough if this doesn't
panic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
