CurtHagenlocher commented on code in PR #3682:
URL: https://github.com/apache/arrow-adbc/pull/3682#discussion_r2491357936
##########
csharp/Benchmarks/Benchmarks.csproj:
##########
@@ -23,6 +23,9 @@
<ProjectReference
Include="..\src\Apache.Arrow.Adbc\Apache.Arrow.Adbc.csproj" />
<ProjectReference Include="..\src\Client\Apache.Arrow.Adbc.Client.csproj"
/>
<ProjectReference
Include="..\src\Drivers\Databricks\Apache.Arrow.Adbc.Drivers.Databricks.csproj"
/>
+ </ItemGroup>
+
+ <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
Review Comment:
The issue here is that .NET 4.7.2 is not supported on non-Windows platforms,
so the project Apache.Arrow.Adbc.Tests only targets it on Windows. Instead of
having a conditional here on the `TargetFramework` we could follow the same
pattern for the project as a whole and define `TargetFrameworks` as
```
<TargetFrameworks
Condition="'$(IsWindows)'=='true'">net8.0;net472</TargetFrameworks>
<TargetFrameworks
Condition="'$(TargetFrameworks)'==''">net8.0</TargetFrameworks>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
