ritchie46 commented on pull request #35: URL: https://github.com/apache/arrow-datafusion/pull/35#issuecomment-825614700
> Looks good @ritchie46 -- thank you! > > I think all that is missing is some sort of test that exercises this codepath (to ensure that we don't accidentally break / regress in this functionality in the future) > > Perhaps you might following the model of `group_by_dictionary`: https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/execution/context.rs#L1650 Thanks, for pointing me in the direction. I still need to get a bit more familiar with this code base. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
