Dandandan commented on code in PR #8849:
URL: https://github.com/apache/arrow-rs/pull/8849#discussion_r2531984891
##########
arrow-ord/src/cmp.rs:
##########
@@ -390,14 +390,14 @@ fn take_bits(v: &dyn AnyDictionaryArray, buffer:
BooleanBuffer) -> BooleanBuffer
/// Invokes `f` with values `0..len` collecting the boolean results into a new
`BooleanBuffer`
///
-/// This is similar to [`MutableBuffer::collect_bool`] but with
+/// This is similar to [`arrow_buffer::MutableBuffer::collect_bool`] but with
/// the option to efficiently negate the result
fn collect_bool(len: usize, neg: bool, f: impl Fn(usize) -> bool) ->
BooleanBuffer {
- let mut buffer = MutableBuffer::new(ceil(len, 64) * 8);
+ let mut buffer = Vec::with_capacity(ceil(len, 64));
Review Comment:
That makes sense, I was thinking about it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
