scott-routledge2 opened a new pull request, #48171:
URL: https://github.com/apache/arrow/pull/48171

   Thanks for opening a pull request!
   
   If this is your first pull request you can find detailed information on how 
to contribute here:
   
     * [New Contributor's 
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
     * [Contributing 
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
   
   Please remove this line and the above text before creating your pull request.
   
   ### Rationale for this change
   
   Casting Binary offset -> Binary offset types relies on ZeroCopyCastExec, 
which propagates the offset of the input to the output. This can lead to larger 
allocations than necessary when casting arrays with offsets. 
   
   See https://github.com/apache/arrow/issues/43660 and
   https://github.com/apache/arrow/pull/43661 for more context.
   
   ### What changes are included in this PR?
   
   Ensure output array has a small offset (it can still be non-zero since 
reusing the null bitmap requires in_offset % 8 == out_offset % 8)
   
   ### Are these changes tested?
   
   Ran unit tests.
   
   ### Are there any user-facing changes?
   
   **This PR includes breaking changes to public APIs.** (If there are any 
breaking changes to public APIs, please explain which changes are breaking. If 
not, you can remove this.)
   
   **This PR contains a "Critical Fix".** (If the changes fix either (a) a 
security vulnerability, (b) a bug that caused incorrect or invalid data to be 
produced, or (c) a bug that causes a crash (even when the API contract is 
upheld), please provide explanation. If not, you can remove this.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to