brancz commented on code in PR #8871:
URL: https://github.com/apache/arrow-rs/pull/8871#discussion_r2543564481
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -10836,11 +10890,11 @@ mod tests {
let int = Arc::new(Int32Array::from(vec![42, 28, 19, 31]));
let struct_array = StructArray::from(vec![
(
- Arc::new(Field::new("b", DataType::Boolean, false)),
+ Arc::new(Field::new("a", DataType::Boolean, false)),
Review Comment:
It’s possible someone had it incorrect with it accidentally working but I
don’t think that should stop fixing what’s clearly a bug. The previous behavior
can actually cause very hidden unexpected behavior when it does accidentally
work but field names mismatch or have a different order. I can’t see a valid
use case for the incorrect previous behavior and all valid behaviors can be
represented still and on total mismatches a user will even get a proper error
now instead of potentially silently continuing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
