adamreeve commented on code in PR #8305:
URL: https://github.com/apache/arrow-rs/pull/8305#discussion_r2545205385
##########
parquet/src/file/metadata/writer.rs:
##########
@@ -758,13 +758,42 @@ impl MetadataObjectWriter {
match column_chunk.column_crypto_metadata.as_deref() {
None => {}
Some(ColumnCryptoMetaData::ENCRYPTION_WITH_FOOTER_KEY) => {
+ use crate::file::metadata::thrift::serialize_column_meta_data;
// When uniform encryption is used the footer is already
encrypted,
// so the column chunk does not need additional encryption.
+ // Except if we're in plaintext footer mode, then we need to
encrypt
+ // the column metadata here.
+ let is_footer_encrypted =
file_encryptor.properties().encrypt_footer();
+
+ if !is_footer_encrypted {
+ // Temporarily clear crypto_metadata so statistics get
included in encrypted blob
Review Comment:
We don't need this step if we check for `encrypted_column_metadata` instead
of `crypto_metadata` in `serialize_column_meta_data`
(https://github.com/apache/arrow-rs/pull/8305/files#r2543948275)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
