Ext3h commented on code in PR #48192:
URL: https://github.com/apache/arrow/pull/48192#discussion_r2546811701
##########
cpp/src/arrow/util/compression_zstd.cc:
##########
@@ -207,8 +226,18 @@ class ZSTDCodec : public Codec {
Result<int64_t> Compress(int64_t input_len, const uint8_t* input,
int64_t output_buffer_len, uint8_t* output_buffer)
override {
- size_t ret = ZSTD_compress(output_buffer,
static_cast<size_t>(output_buffer_len),
- input, static_cast<size_t>(input_len),
compression_level_);
+ if (!compression_context_) {
Review Comment:
And there's a weird mismatch in the `Compressor` interface - it does not
support context/state-recycling even though all of the backing interfaces
actually do. It always assumes that the context/state would be dead after a
single compression pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
