friendlymatthew commented on code in PR #8839:
URL: https://github.com/apache/arrow-rs/pull/8839#discussion_r2557914193
##########
arrow-row/src/lib.rs:
##########
@@ -1762,6 +1901,110 @@ unsafe fn decode_column(
},
_ => unreachable!(),
},
+ Codec::Union(converters, null_rows, _mode) => {
+ let len = rows.len();
+
+ let DataType::Union(union_fields, mode) = &field.data_type else {
+ unreachable!()
Review Comment:
I'm not sure if it's worth writing a descriptive message when the branch is
specifically designed for a case that will never hit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
