pixelherodev commented on PR #578: URL: https://github.com/apache/arrow-go/pull/578#issuecomment-3573833846
> That's a good thing to check. My opinion here is the desire to make things as simple as possible and avoid having to deal with the dependency graph like that. Agreed. It's likely worth it even if it does; more overhead than this approach maybe, but less code / correctness concerns, and still a savings over the current implementation :) > In addition, the closure approach would also make the transition to add cleanup much easier Yeah, that's a really good point. We'd basically need two flags - the question is, is it one for "do any tracking" and one for "refcount vs addcleanup", or is it one for refcounting and one for addcleanup, and the combination is invalid? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
