alamb commented on code in PR #8921:
URL: https://github.com/apache/arrow-rs/pull/8921#discussion_r2560896405
##########
parquet-variant-compute/src/variant_get.rs:
##########
@@ -3775,14 +3775,15 @@ mod test {
let err = variant_get(&variant_array, options).unwrap_err();
assert!(
err.to_string().contains(
- "Cast error: Cast failed at index 0 (array type: Time64(µs)):
Invalid microsecond from midnight: 86401000000"
- )
+ "Cast error: Failed to extract primitive of type Time64(µs)
from variant Int64(86401000000) at path VariantPath([])"
Review Comment:
the case still errors, but the message is different
##########
parquet-variant-compute/src/variant_get.rs:
##########
@@ -3751,18 +3751,18 @@ mod test {
}
}
-
perfectly_shredded_variant_array_fn!(perfectly_shredded_invalid_time_variant_array,
|| {
+ fn invalid_time_variant_array() -> ArrayRef {
+ let mut builder = VariantArrayBuilder::new(3);
// 86401000000 is invalid for Time64Microsecond (max is 86400000000)
- Time64MicrosecondArray::from(vec![
- Some(86401000000),
Review Comment:
This is an invalid Time64MicrosecondArray and thus I would expect this array
to be impossible to create with `shred_variant` (I would expect shred_variant
to error)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
