trxcllnt commented on code in PR #340:
URL: https://github.com/apache/arrow-js/pull/340#discussion_r2560933326
##########
src/builder/struct.ts:
##########
@@ -21,9 +21,23 @@ import { Field } from '../schema.js';
import { Builder } from '../builder.js';
import { Struct, TypeMap } from '../type.js';
+/** @ignore */
+type StructValue<T extends TypeMap = any> = Struct<T>['TValue'] | { [P in
keyof T]: T[P]['TValue'] };
Review Comment:
Is this needed because of a Typescript version bump? This used to work
because the mapping [is part
of](https://github.com/apache/arrow-js/blob/main/src/row/struct.ts#L28-L30) the
`Struct<T>['TValue']` aka `StructRowProxy<T>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
