felipecrv commented on code in PR #3714:
URL: https://github.com/apache/arrow-adbc/pull/3714#discussion_r2566823513
##########
rust/core/src/non_blocking.rs:
##########
@@ -19,48 +19,45 @@ use arrow_array::{RecordBatch, RecordBatchReader};
use arrow_schema::Schema;
use std::collections::HashSet;
-use std::future::Future;
use crate::error::Result;
use crate::options::{self, *};
use crate::PartitionedResult;
/// Ability to configure an object by setting/getting options.
-pub trait AsyncOptionable {
- type Option: AsRef<str> + Send;
+#[trait_variant::make(AsyncOptionable: Send)]
Review Comment:
I'm fine with the multiple versions because I like seeing them as totally
different interfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
