alamb commented on issue #7806: URL: https://github.com/apache/arrow-rs/issues/7806#issuecomment-3591614690
> Is this `panic!` useful, or can it be returned as an `Err(General())` like other branches in this function? If we do want to `panic!` is this reachable? > > [arrow-rs/parquet/src/schema/visitor.rs](https://github.com/apache/arrow-rs/blob/5595019bad5f7fa8c75106d31bf86c8c99d2822c/parquet/src/schema/visitor.rs#L54) > > Line 54 in [5595019](/apache/arrow-rs/commit/5595019bad5f7fa8c75106d31bf86c8c99d2822c) > > panic!("{list_type:?} is a list type and must be a group type") I have no idea if it is reachable. Returning Err(General(..) with some message saying an unexpected/ invalid error occured, seems like a good idea to me and follows the guidelines: https://github.com/apache/arrow-rs?tab=readme-ov-file#guidelines-for-panic-vs-result -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
