friendlymatthew commented on code in PR #8933:
URL: https://github.com/apache/arrow-rs/pull/8933#discussion_r2572990002
##########
arrow-array/src/array/mod.rs:
##########
@@ -824,20 +824,20 @@ pub fn make_array(data: ArrayData) -> ArrayRef {
DataType::UInt16 =>
Arc::new(DictionaryArray::<UInt16Type>::from(data)) as ArrayRef,
DataType::UInt32 =>
Arc::new(DictionaryArray::<UInt32Type>::from(data)) as ArrayRef,
DataType::UInt64 =>
Arc::new(DictionaryArray::<UInt64Type>::from(data)) as ArrayRef,
- dt => panic!("Unexpected dictionary key type {dt}"),
+ dt => unimplemented!("{dt}"),
},
DataType::RunEndEncoded(run_ends_type, _) => match
run_ends_type.data_type() {
DataType::Int16 => Arc::new(RunArray::<Int16Type>::from(data)) as
ArrayRef,
DataType::Int32 => Arc::new(RunArray::<Int32Type>::from(data)) as
ArrayRef,
DataType::Int64 => Arc::new(RunArray::<Int64Type>::from(data)) as
ArrayRef,
- dt => panic!("Unexpected data type for run_ends array {dt}"),
+ dt => unimplemented!("{dt}"),
},
DataType::Null => Arc::new(NullArray::from(data)) as ArrayRef,
DataType::Decimal32(_, _) => Arc::new(Decimal32Array::from(data)) as
ArrayRef,
DataType::Decimal64(_, _) => Arc::new(Decimal64Array::from(data)) as
ArrayRef,
DataType::Decimal128(_, _) => Arc::new(Decimal128Array::from(data)) as
ArrayRef,
DataType::Decimal256(_, _) => Arc::new(Decimal256Array::from(data)) as
ArrayRef,
- dt => panic!("Unexpected data type {dt}"),
+ dt => unimplemented!("{dt}"),
Review Comment:
Hi hi! Would it be possible to add a message that not only explains which
data type is unimplemented, but also for which specific use case?
For example: `unimplemented!("unexpected dictionary key type {dt}")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
