etseidl commented on code in PR #8889:
URL: https://github.com/apache/arrow-rs/pull/8889#discussion_r2578973043
##########
parquet/src/column/reader.rs:
##########
@@ -466,9 +472,12 @@ where
self.def_level_decoder
.as_mut()
.unwrap()
- .set_data(def_level_encoding, level_data)?;
+ .set_data(def_level_encoding, level_data);
}
+ if offset > buf.len() {
Review Comment:
Looking at it more, I think this error checking needs to move into
`parse_v1_levels` which can still panic. If that doesn't return an error, then
we don't need to check again here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
